[FrameworkBundle] move wiring of the property info extractor to the ObjectNormalizer #54791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @mtarld |
mtarld
approved these changes
Apr 30, 2024
xabbuh
force-pushed
the
pr-52917
branch
3 times, most recently
from
a02e11f
to
7680056
Compare
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
The PropertyNormalizer does not handle a property info extractor. It looks like the argument was accidentally added to instead of the ObjectNormalizer in symfony#52917.
dunglas
approved these changes
Apr 30, 2024
chalasr
approved these changes
May 1, 2024
|
Good catch, thanks @xabbuh. |
This was referenced May 26, 2024
This was referenced Jun 2, 2024
Merged
Merged
Merged
|
I think #57293 breaks v7.0.8. Upgrading FrameworkBundle from 7.0.7 to 7.0.8 triggers this: Downgrading symfony/framework-bundle (v7.0.8 => v7.0.7): Extracting archive |
fabpot
added a commit
that referenced
this pull request
Jun 15, 2024
…normalizers (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] Fix setting default context for certain normalizers | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #56875, fix #57316 | License | MIT Caused by #54791. The main problem is that `$context` defaults to `[]` instead of `$defaultContext`. There's a test to check this, but it didn't work when `circular_reference_handler` or `max_depth_handler` were not `null`. I also found an issue with `serializer.normalizer.property`. Since it’s not tagged with `serializer.normalizer`, which, to my understanding, is intentional, it would never have the default context bound to it. Commits ------- f903893 [FrameworkBundle] Fix setting default context for certain normalizers
|
#57297 was merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PropertyNormalizer does not handle a property info extractor. It looks like the argument was accidentally added to instead of the ObjectNormalizer in #52917.