Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Strings][EnglishInflector] Fix incorrect pluralisation of 'Album' #54794

Merged
merged 1 commit into from
May 1, 2024

Conversation

timporter
Copy link
Contributor

Previously it incorrectly returned 'Alba' for 'Album', should be 'Albums'

Q A
Branch? 7.0
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

I noticed this with Platform API. Creating an Entity call "Album", for the endpoints it would generate "/api/alba/{id}', which is wrong, should be '/api/albums/{id}'

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a testcase? Thanks

@timporter
Copy link
Contributor Author

timporter commented May 1, 2024

Can you please add a testcase? Thanks

I would be happy to but from my limited understanding there are no existing tests against this class, if you can point me at any I will sort that out.

Found some, will edit

@fabpot
Copy link
Member

fabpot commented May 1, 2024

Thank you @timporter.

@fabpot fabpot merged commit c5e56bb into symfony:5.4 May 1, 2024
5 of 11 checks passed
@fabpot fabpot modified the milestones: 7.0, 5.4 May 1, 2024
@timporter timporter deleted the FixPluralisationOfAlbum branch May 1, 2024 14:03
This was referenced Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants