Fix exception thrown during LDAP_MODIFY_BATCH_REMOVE_ALL batch operations

[phasdev]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #54829
License	MIT

Bugfix removes values array element for LDAP_MODIFY_BATCH_REMOVE_ALL operations. PHP throws an exception when this element is included.

Testing this component is complicated by the fact that most tests are skipped unless there's a local LDAP server running. To create a test which demonstrated the issue and fix, I created a default GitHub Codespace and ran the attached shell commands. These commands install and configure a local OpenLDAP server. You'll probably need to do something similar to confirm the issue/fix.

setup-ldap-codespace.md

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[carsonbot]

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

[xabbuh]

LGTM

[fabpot]

Thank you @phasdev.