Rename object to data in NormalizerInterface::normalize

[maxbeckers]

Q	A
Branch?	7.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #54774
License	MIT

Rename sttribure of Serializer::normalize to the naming of the interface to make the usage of named attributes possible.

From the discussion of this PR I changed it to rename the first parameter of NormalizerInterface::normalize from object to data because it can't handle only objects, it's type mixed.

[nicolas-grekas]

I think we'd better not do this: named arguments are out of the BC promise, so using named arguments is a terrible argument for this change :) Also, this interface accepts mixed, not only objects, so $data is a more appropriate name. We might want to change the interface instead.

[russelomua]

I was anticipating a discussion, so I was surprised by the sudden appearance of this PR. I agree, @nicolas-grekas, but would modifying the interface be a BC?

[maxbeckers]

Yeah i just opened this PR to push the discussion about it because it took just a few seconds to prepare this PR. I'm open to close this PR with "Won't Fix" or even take the topic to change the interface as Nicolas mentioned.
I can take it with me and change the interface and all related classes to bring them in sync.

And when we want to change it, is it really a bugix or should we do this in 7.2?

[scruwi]

IMO those interface changes are rather BC than changes of implemantation.

[nicolas-grekas]

Named arguments out of our BC promise. Also, changing argument names on interfaces cannot break existing code since PHP maps to arguments found in concrete implementations, not in abstract ones.

[nicolas-grekas]

That'd be for 7.2, it's not a bug fix but just a tweak.

[nicolas-grekas]

I'd suggest changing only the interface

[maxbeckers]

Don't we want to keep the other classes in sync with the interface?

[stof]

Renaming all implementations will increase the risk of conflicts when merging between branches.
And the argument name in our implementations does not really matter for users of Symfony (as we don't support named parameters in our BC policy anyway, and covering them with BC would have prevented the renaming entirely).