[FrameworkBundle] Exclude constraints from container #54887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
force-pushed
the
constraint-services
branch
from
0224ff2
to
df6e3c3
Compare
javiereguiluz
changed the title
|
Hello, IIRC, I did the same patch in order to try, and I didn't work. Are you 100% sure it remove theses services from the container? |
OskarStark
changed the title
|
This should use registerForAutoconfiguration instead, the current code defines a local-only rule, but I suppose you want to exclude constraints defined by apps, isn't it? |
|
Note : I tested with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constraints should not be registered as services but since Constraints and Validators are usually in the same directory, constraints can not be excluded using the path but only via instanceof.