[Console] Add check for posix_kill function

[k-sahara]

Q	A
Branch?	7.1
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #54892
License	MIT

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[MatTheCat]

Hello, just some feedback:

• PHPUnit offers a requires annotation which can automatically skip tests if an extension is missing; this is better than sprinkling calls to function_exists (you can see Symfony already @requires extension pcntl on the test methods you modified).

• POSIX functions are used by quite a few other test cases, so it would probably make sense to update these as well.

• You targeted the 7.1 branch, but POSIX functions are present in tests since at least 5.4.

At last, the POSIX extension is supposed to be enabled by default, so I’m not sure core Symfony members would want to add checks for it 🤔

[alexandre-daubois]

PHPUnit offers a requires annotation which can automatically skip tests if an extension is missing; this is better than sprinkling calls to function_exists (you can see Symfony already @requires extension pcntl on the test methods you modified).

You can even use @requires function posix_kill at the top of your tests 👍

[nicolas-grekas]

the POSIX extension is supposed to be enabled by default

This means to me we might not want to merge this PR indeed.
E.g. adding requires function json_encode would also be no-go