[DoctrineBridge] Fix UniqueEntityValidator with proxy object
#57188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
force-pushed
the
fix-uniqueentityvalidator-with-proxy-object
branch
from
add9ceb
to
028dbbb
Compare
HypeMC
force-pushed
the
fix-uniqueentityvalidator-with-proxy-object
branch
from
028dbbb
to
99f279b
Compare
dmaicher
approved these changes
May 27, 2024
dmaicher
reviewed
May 27, 2024
src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php
Show resolved
Hide resolved
wkania
approved these changes
May 29, 2024
xabbuh
reviewed
May 29, 2024
src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php
Show resolved
Hide resolved
xabbuh
reviewed
May 29, 2024
src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php
Show resolved
Hide resolved
xabbuh
approved these changes
May 30, 2024
stof
approved these changes
May 31, 2024
|
Thank you @HypeMC. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #38662,
$fieldValue = $class->reflFields[$fieldName]->getValue($entity);was used to get the value of a property, so it makes sense to keep using it when the object is an entity.