Fix upgrade prototype name option #5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2012 10:33
I don't think this was even possible in 2.0
| @@ -423,22 +423,13 @@ | |||
| * In the collection type's template, the default name of the prototype field | |||
| has changed from `$$name$$` to `__name__`. | |||
|
|
|||
| For custom names, dollar signs are no longer prepended and appended. You are | |||
There was a problem hiding this comment.
Why do you want to remove this part?
There was a problem hiding this comment.
Because I don't remember this was even possible in 2.0 ... the documentation says the "prototype" option is supposed to be a boolean, so the 'prototype' => 'proto', part looks very dubious to me. And the $$name$$ default does not look it is configurable at all in the code in 2.0... what do you think?
fabpot
added a commit
that referenced
this pull request
Oct 25, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.