[WDT] Toolbar cleanups #6615
Closed
[WDT] Toolbar cleanups #6615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just pushed a couple more changes that cleanup WDT popup boxes a little bit. Again the changes are subtle, but better imo. Before: After: Before: After: Note: requires cross-browser testing |
|
Somebody ought to test this cross-browser (e.g. IE). Renders fine in Chrome/Safari/Firefox. |
|
Renders fine in Opera |
ondrejmirtes
pushed a commit
to ondrejmirtes/symfony
that referenced
this pull request
Nov 25, 2013
This PR was merged into the master branch. Commits ------- 4b54156 Fix lack of padding in some WDT boxes (e.g. You are not authenticated.) Discussion ---------- [WebProfilerBundle] Fix lack of padding in some WDT boxes (e.g. You are not authenticated.) Fixes bug introduced by symfony#6615 Before:  After: 
gencer
pushed a commit
to gencer/Yaml
that referenced
this pull request
Jul 29, 2014
This PR was merged into the master branch. Commits ------- 4b54156 Fix lack of padding in some WDT boxes (e.g. You are not authenticated.) Discussion ---------- [WebProfilerBundle] Fix lack of padding in some WDT boxes (e.g. You are not authenticated.) Fixes bug introduced by symfony/symfony#6615 Before:  After: 
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
This PR was squashed before being merged into the master branch (closes symfony#6615). Commits ------- 490c746 [WDT] Toolbar cleanups Discussion ---------- [WDT] Toolbar cleanups Ok this is ridiculously minor, but it's one of those little things that winds me up on a daily basis so I fixed it. When you mouseover a section on the WDT, the box-shadow is blurry on the right edge. Edit: this PR now covers a few other minor tweaks - see below. --------------------------------------------------------------------------- by lmcd at 2013-01-09T07:41:42Z Just pushed a couple more changes that cleanup WDT popup boxes a little bit. Again the changes are subtle, but better imo. Before:  After:  Before:  After:  Note: requires cross-browser testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok this is ridiculously minor, but it's one of those little things that winds me up on a daily basis so I fixed it.
When you mouseover a section on the WDT, the box-shadow is blurry on the right edge.
Edit: this PR now covers a few other minor tweaks - see below.