[2.3] [Form] New CollectionType prototype_data option

[adrienbrault]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#5095
License	MIT
Doc PR	symfony/symfony-docs#2192

Hey

[stof]

you should provide a doc PR

[adrienbrault]

I've created a PR on the documentation for this feature.

[adrienbrault]

In case anyone can't wait for this feature to be merged (or is still using 2.1), here's a FormTypeExtension that provides the same feature https://gist.github.com/4666086 .

[vicb]

What about a more generic prototype-option ?

[stof]

@vicb there is already options to pass option for all children. There is not a lot of options where it makes sense to distinguish the prototype or other children IMO (but the data is one as the prototype does not have mapped data)

[vicb]

Are nesting or user defined options some uc ? (note to myself: merge)

[gimler]

ping

[stof]

@gimler this is a new feature, and 2.2 is in its RC cycle. So it would have to wait for 2.3. The priority currently is to stabilize 2.2, not to merge PRs for 2.3

[pborreli]

imho, using a assignement here is confusing and not really needed

[webmozart]

I agree with @pborreli. Please change this to test directly against 'foobar' below.

[Bendihossan]

Does any more work need doing to this other than updating the test that @pborreli mentioned? It would be great to get this in 2.1 as well as 2.2 if possible.

[webmozart]

ref #6350

[webmozart]

ref #3825

[peterrehm]

@bschussek Will this addition get into 2.3?

[mvrhov]

No. 2.3 is in feature freeze.

[peterrehm]

This I know, I just wanted to ping again to get the state. Its pending now for some time, hope that it will quickly get in.

[Venzon]

also looking for this feature
is there any way to set default values for prototype object?

[stof]

@Venzon As said above, it is easy to do it usign a type extension waiting for it to be merged. See the gist linked by @adrienbrault

[Venzon]

@stof thanks a lot, I did not notice this gist

[Venzon]

@adrienbrault @stof
I did try to use CollectionTypeExtension (https://gist.github.com/4666086) by @adrienbrault but it does not work for me. Is my implementation somehow wrong? Defining prototype_data option inside TagType does not work aswell. Please help ^^

$builder->add('tags', 'collection', array(
    'type' => new TagType(),
    'allow_add' => true,
    'allow_delete' => true,
    'prototype_data' => function() {
        $object = new Tag();
        $object->setName('test')->setIsActive(true);
        return $object;
    },
));

Inside TagType class

public function setDefaultOptions(OptionsResolverInterface $resolver)
{
    $resolver->setDefaults(array(
        'data_class' => 'Acme\TaskBundle\Entity\Tag',
        'prototype_data' => function() {
            $object = new Tag();
            $object->setName('test')->setIsActive(true);
            return $object;
        },
    ));
}

[webmozart]

Closed in favor of #9177

[stof]

@bschussek I'm not sure the related issue would allow fixing it: it should overwrite the data option only for the prototype, not for all children