[2.2][HttpKernel] Extract the bundles building code #7396
Conversation
|
Can you explain your use case a bit more? |
|
I don't use bundles for app specific code and I need to add a security listener factory to the security extension. Usually this is done in the Doing this before the |
|
Why not using the |
|
see #7437 for an alterative patch. |
|
How would I get the currently used container builder in the |
|
I figured that out after posting my comment. That's why I've made a PR which I think is better than this one. What do you think? |
|
Looks good and would allow to resolve my use case. |
|
Closing in favor of #7437 |
This PR was merged into the master branch. Commits ------- 7c3179a [HttpKernel] moved the Container compilation for more flexibility 757194c [HttpKernel] made the Kernel class more flexible (closes #7396) Discussion ---------- [HttpKernel] made the Kernel class more flexible (closes #7396) | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7396 | License | MIT | Doc PR | n/a --------------------------------------------------------------------------- by jrobeson at 2013-03-20T14:04:53Z I still (personally) think that the compile() method is still too close to the building of the container. Is there a reasonable way to move the compile() method away from the rest of the logic used to build the container? --------------------------------------------------------------------------- by elnur at 2013-03-20T14:34:23Z I like this one. Can't wait to see this merged. --------------------------------------------------------------------------- by stof at 2013-03-20T14:50:22Z @jrobeson compiling the container is part of building it (it is the step running the compiler passes) --------------------------------------------------------------------------- by jrobeson at 2013-03-20T15:32:26Z i read the code stof .. that is what it does :) . I just thought it'd be easier to modify the container from the kernel of the compile() call was placed after the buildContainer() call at https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Kernel.php#L556 This is something i had to work around when migrating to symfony. It's not a big deal to me anymore, so no worries. --------------------------------------------------------------------------- by stof at 2013-03-20T15:36:12Z @jrobeson the container is not fully build until you compile it. Half of the work is done by the compile() call. --------------------------------------------------------------------------- by fabpot at 2013-03-20T15:38:24Z I've moved the compile method as it makes things even more flexible. --------------------------------------------------------------------------- by jrobeson at 2013-03-20T15:41:45Z @stof : i know .. which is even better reason to move it outside that big method. @fabpot: thanks!
At least I need that method extracted to be able to add my own code to it