Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few optimizations #7931

Merged
merged 3 commits into from
May 6, 2013
Merged

A few optimizations #7931

merged 3 commits into from
May 6, 2013

Commits on May 4, 2013

  1. [HttpFoundation] Optimize ServerBag::getHeaders() 

    isset() vs in_array makes it take half the time (1ms/req here)
substr() does not have to scan the whole string so it's a wee bit faster
    @Seldaek
    Seldaek committed May 4, 2013
    Configuration menu
    Copy the full SHA
    f5e7f24 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2013

  1. [HttpFoundation] Avoid a few unnecessary str_replace() calls

    @Seldaek
    Seldaek committed May 5, 2013
    Configuration menu
    Copy the full SHA
    997d549 View commit details
    Browse the repository at this point in the history

  2. [HttpKernel] Avoid updating the context if the request did not change 

    Due to the BC $this->setRequest() call in the onKernelRequest method, the
request is set twice every time in Symfony, and RequestContext::fromRequest
takes 1ms to run here so if we can skip one call it is a win.
    @Seldaek
    Seldaek committed May 5, 2013
    Configuration menu
    Copy the full SHA
    ea633f5 View commit details
    Browse the repository at this point in the history