Patch property accessor exception #7999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for some other opinions about what to really do: throwing a new NoSuchIndexException or throwing the already existant NoSuchPropertyException (is it really relevant to distinguish Index from Property access?) |
|
Hi, I one more time encountered this little issue in on of my projects (issue... I had to take into account that trying to get a nonexistent property from an array behaves like retrieving an null value from an existing property in an array). @stof , could we discuss about this PR please? Do I have to change anything? |
|
Closing in favor of #9148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion on issue #7881.