extract clone duplication logic in exceptionlistener #8716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You broke tests as you changed type of |
|
Good point. I am wondering whether adding Request in the use statements is right, as this kind of add a new depedency of the http kernel on the http foundation. Maybe this is already the case, so that is not a problem. |
|
Yep. Already the case: |
| /** | ||
| * Clone the request for the exception. | ||
| * | ||
| * @param \Exception $exception |
There was a problem hiding this comment.
All phpdoc should in one line, the only exception is when description is really long.
There was a problem hiding this comment.
Thank you! There we go
|
Looks good to me. |
|
Thank you for the review ... fixed the codestyle issues. |
fabpot
added a commit
that referenced
this pull request
Aug 10, 2013
This PR was merged into the master branch. Discussion ---------- extract clone duplication logic in exceptionlistener Drupal needs potentially to adapt the exception listener to add more information from the original request. (see http://drupal.org/node/2057607) so what about extracing some of the logic into a new method. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT Commits ------- 6af2801 extract method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drupal needs potentially to adapt the exception listener to add more information from the original request. (see http://drupal.org/node/2057607) so what about extracing some of the logic into a new method.