New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronized Service alternative, backwards compatible #8904
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c55f1ea
added a RequestStack class
beberlei a58a8a6
[HttpKernel] changed request_stack to a private service
fabpot f9b10ba
[HttpKernel] renamed the kernel finished event
fabpot 018b719
[HttpKernel] tweaked the code
fabpot 93e60ea
[HttpKernel] modified listeners to be BC with Symfony <2.4
fabpot b1a062d
moved RequestStack to HttpFoundation and removed RequestContext
fabpot 1b2ef74
[Security] made sure that the exception listener is always removed fr…
fabpot File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\HttpFoundation; | ||
|
||
/** | ||
* Request stack that controls the lifecycle of requests. | ||
* | ||
* @author Benjamin Eberlei <kontakt@beberlei.de> | ||
*/ | ||
class RequestStack | ||
{ | ||
/** | ||
* @var Request[] | ||
*/ | ||
private $requests = array(); | ||
|
||
/** | ||
* Pushes a Request on the stack. | ||
* | ||
* This method should generally not be called directly as the stack | ||
* management should be taken care of by the application itself. | ||
*/ | ||
public function push(Request $request) | ||
{ | ||
$this->requests[] = $request; | ||
} | ||
|
||
/** | ||
* Pops the current request from the stack. | ||
* | ||
* This operation lets the current request go out of scope. | ||
* | ||
* This method should generally not be called directly as the stack | ||
* management should be taken care of by the application itself. | ||
* | ||
* @return Request | ||
*/ | ||
public function pop() | ||
{ | ||
if (!$this->requests) { | ||
throw new \LogicException('Unable to pop a Request as the stack is already empty.'); | ||
} | ||
|
||
return array_pop($this->requests); | ||
} | ||
|
||
/** | ||
* @return Request|null | ||
*/ | ||
public function getCurrentRequest() | ||
{ | ||
return end($this->requests) ?: null; | ||
} | ||
|
||
/** | ||
* Gets the master Request. | ||
* | ||
* Be warned that making your code aware of the master request | ||
* might make it un-compatible with other features of your framework | ||
* like ESI support. | ||
* | ||
* @return Request|null | ||
*/ | ||
public function getMasterRequest() | ||
{ | ||
if (!$this->requests) { | ||
return null; | ||
} | ||
|
||
return $this->requests[0]; | ||
} | ||
|
||
/** | ||
* Returns the parent request of the current. | ||
* | ||
* Be warned that making your code aware of the parent request | ||
* might make it un-compatible with other features of your framework | ||
* like ESI support. | ||
* | ||
* If current Request is the master request, it returns null. | ||
* | ||
* @return Request|null | ||
*/ | ||
public function getParentRequest() | ||
{ | ||
$pos = count($this->requests) - 2; | ||
|
||
if (!isset($this->requests[$pos])) { | ||
return null; | ||
} | ||
|
||
return $this->requests[$pos]; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,11 @@ | ||
CHANGELOG | ||
========= | ||
|
||
2.4.0 | ||
----- | ||
|
||
* added the KernelEvents::FINISH_REQUEST event | ||
|
||
2.3.0 | ||
----- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
src/Symfony/Component/HttpKernel/Event/FinishRequestEvent.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\HttpKernel\Event; | ||
|
||
/** | ||
* Triggered whenever a request is fully processed. | ||
* | ||
* @author Benjamin Eberlei <kontakt@beberlei.de> | ||
*/ | ||
class FinishRequestEvent extends KernelEvent | ||
{ | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a bc break. when a user uses this listener without passing a request stack, he will automatically get this exception because the event is subscribed automatically as well by the listener.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9059