[FrameworkBundle] use the new request_stack service to get the Request object in the base Controller class #9553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hhamon
commented
Nov 20, 2013
hhamon
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
|
👍 |
|
Can you mark this method as deprecated in 2.4 (with a removal in 3.0?) And update the UPGRADE-3.0 file accordingly. I don't even know why we added this in the first place as you can easily get the request by type hinting it in any action method. Thanks. |
|
@fabpot done! |
|
Forgot to add a note in Ugrade file... I'm on it. |
|
Should I squash the three commits? |
| * | ||
| * @deprecated Deprecated since version 2.4, to be removed in 3.0. Ask | ||
| * Symfony to inject the Request object into your controller | ||
| * method instead by typing it in the method's signature. |
There was a problem hiding this comment.
by typing looks weird to me. by type hinting?
There was a problem hiding this comment.
yep type hinting is better.
…t object in the base Controller class
|
Thanks! I have fixed the UPGRADE file and the PHPDoc. Commits have been squashed together. |
fabpot
added a commit
that referenced
this pull request
Nov 21, 2013
…the Request object in the base Controller class (hhamon) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle] use the new request_stack service to get the Request object in the base Controller class | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 2e07338 [FrameworkBundle] use the new request_stack service to get the Request object in the base Controller class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.