Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Composer 2 #84

Closed
AegirLeet opened this issue Apr 7, 2020 · 1 comment
Closed

Support Composer 2 #84

AegirLeet opened this issue Apr 7, 2020 · 1 comment

Comments

@AegirLeet
Copy link

symfony/thanks currently requires composer-plugin-api ^1.0, making it incompatible with Composer 2. See composer/composer#8726.

@Ayesh
Copy link
Contributor

Ayesh commented Apr 15, 2020

I'm working on this. I'll send a PR shortly.

nicolas-grekas added a commit that referenced this issue May 30, 2020
This PR was merged into the 1.2-dev branch.

Discussion
----------

Add support for composer-plugin-api v2

Composer version 2 has `composer-plugin-api` version 2, and this plugin attemts to support both API versions.

See [What's new in Composer 2](https://php.watch/articles/composer-2) and [UPGRADE-2.0](https://github.com/composer/composer/blob/master/UPGRADE-2.0.md#for-integrators-and-plugin-authors) for more changes in API.

 - Empty methods `\Symfony\Thanks\Thanks::deactivate()` and `\Symfony\Thanks\Thanks::uninstall()` are added to make it compatible both versions.
 - On Composer v2, `\Hirak\Prestissimo\CurlRemoteFilesystem` is not used in favor of Composer's native `\Composer\Util\HttpDownloader` which make multiple Curl connections.

Related: #84 and composer/composer#8726.

`thanks` 🙏

Commits
-------

7502bef Add support for composer-plugin-api v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants