Restricting chart.js to 3.8.2 #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-richard
approved these changes
Sep 20, 2022
|
Unfortunately, the js-dist job needs to be skipped due to heap size problems. I'm not sure why - but out rollup build looks super inefficient (runs fine locally though) |
weaverryan
force-pushed
the
fix-chartjs-deps
branch
from
c70aa1d
to
8809368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.9, they broke typescript with chart.js/auto - see chartjs/Chart.js#10599
It will be fixed in 4.0... that's the best we can do I think :).
I DID leave the peer dependencies alone, as I believe a user using 3.9 will still work.