Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations. #33

Closed
wants to merge 1 commit into from
Closed

GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations. #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions Context/ExecutionContextInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,10 @@ public function getObject(): ?object;
*
* @internal Used by the validator engine. Should not be called by user
* code.
*
* @return void
*/
public function setNode(mixed $value, ?object $object, MetadataInterface $metadata = null, string $propertyPath): void;
public function setNode(mixed $value, ?object $object, MetadataInterface $metadata = null, string $propertyPath);

/**
* Sets the currently validated group.
Expand All @@ -136,16 +138,20 @@ public function setNode(mixed $value, ?object $object, MetadataInterface $metada
*
* @internal Used by the validator engine. Should not be called by user
* code.
*
* @return void
*/
public function setGroup(?string $group): void;
public function setGroup(?string $group);

/**
* Sets the currently validated constraint.
*
* @internal Used by the validator engine. Should not be called by user
* code.
*
* @return void
*/
public function setConstraint(Constraint $constraint): void;
public function setConstraint(Constraint $constraint);

/**
* Marks an object as validated in a specific validation group.
Expand All @@ -156,8 +162,10 @@ public function setConstraint(Constraint $constraint): void;
*
* @internal Used by the validator engine. Should not be called by user
* code.
*
* @return void
*/
public function markGroupAsValidated(string $cacheKey, string $groupHash): void;
public function markGroupAsValidated(string $cacheKey, string $groupHash);

/**
* Returns whether an object was validated in a specific validation group.
Expand All @@ -178,8 +186,10 @@ public function isGroupValidated(string $cacheKey, string $groupHash): bool;
*
* @internal Used by the validator engine. Should not be called by user
* code.
*
* @return void
*/
public function markConstraintAsValidated(string $cacheKey, string $constraintHash): void;
public function markConstraintAsValidated(string $cacheKey, string $constraintHash);

/**
* Returns whether a constraint was validated for an object.
Expand Down