Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find the entry "dummy"... Found: entrypoints. #47

Closed
SevenOfSpades opened this issue Mar 1, 2019 · 12 comments
Closed

Could not find the entry "dummy"... Found: entrypoints. #47

SevenOfSpades opened this issue Mar 1, 2019 · 12 comments

Comments

@SevenOfSpades
Copy link
Contributor

SevenOfSpades commented Mar 1, 2019

After update I've got:

[Symfony\WebpackEncoreBundle\Exception\EntrypointNotFoundException]                               
Could not find the entry "dummy" in "/source/public/build/entrypoints.json". Found: entrypoints.

There is indeed catch for EntrypointNotFoundException in EntrypointCacheWarmer but it refers to ymfony\WebpackEncoreBundle\CacheWarmer\EntrypointNotFoundException which does not exist (or my IDE is wrong) but Symfony\WebpackEncoreBundle\Exception\EntrypointNotFoundException exist and is thrown. I assume that use is missing.

EDIT:
I tested it on fresh install and problem exist there too.

@nyroDev
Copy link

nyroDev commented Mar 1, 2019

Same problem here after upgrading from 1.1.0 to 1.2.0

@Amunak
Copy link

Amunak commented Mar 1, 2019

Can confirm; adding use Symfony\WebpackEncoreBundle\Exception\EntrypointNotFoundException; to \Symfony\WebpackEncoreBundle\CacheWarmer\EntrypointCacheWarmer fixes this for the time being.

@gdbonino
Copy link

gdbonino commented Mar 1, 2019

Same problem

@SevenOfSpades
Copy link
Contributor Author

I'm not entirely sure is this the right way to fix it but it's probably the easiest one. I made PR just in case (I needed to fix this in my project anyway).

@pounard
Copy link

pounard commented Mar 2, 2019

Same happened to me today, and @Amunak proposed fix do fix the issue.

@alegout
Copy link

alegout commented Mar 2, 2019

thanks @Amunak

@fabgg
Copy link

fabgg commented Mar 2, 2019

Thanks @Amunak, his solution works fine for me

@kalimerre
Copy link

Same for me :)

@ThePeterMick
Copy link

ThePeterMick commented Mar 2, 2019

Same here, deleting the public/build contents and re-running seems to let composer update succeed...

josemmo added a commit to josemmo/rosetta that referenced this issue Mar 3, 2019
@raress96
Copy link

raress96 commented Mar 3, 2019

Any updates when a new version will be available?I can not do automatic deployment for an app of mine until this is fixed.

weaverryan added a commit that referenced this issue Mar 3, 2019
This PR was merged into the master branch.

Discussion
----------

Add missing use statement in EntrypointCacheWarmer.

Fixes #47

Commits
-------

8429aa5 Add missing use statement in EntrypointCacheWarmer.
@weaverryan
Copy link
Member

Just merged and released the patch fix. Sorry about that! We clearly need an integration test for this layer.

Thanks!

@iluuu1994
Copy link

@weaverryan Consider PHPStan to avoid issues like this? Unless you have 100% coverage things like this can always slip through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests