Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comma missed in index.js #62

Closed
nandakumardevadas opened this issue Jun 30, 2017 · 1 comment · Fixed by #64
Closed

Comma missed in index.js #62

nandakumardevadas opened this issue Jun 30, 2017 · 1 comment · Fixed by #64

Comments

@nandakumardevadas
Copy link

Hi Guys,

Comma missed in the latest tag of index.js at line 360. Encore was not running.

Please do the changes at.
enableTypeScriptLoader(callback) {
webpackConfig.enableTypeScriptLoader(callback);
}

Getting error message SyntaxError: Unexpected identifier
enableVueLoader(vueLoaderOptionsCallback = () => {}) {
@davidmpaz davidmpaz mentioned this issue Jun 30, 2017
Merged
@robertfausk
Copy link
Contributor

Was also wondering yesterday when giving webpack encore a try.

davidmpaz referenced this issue Jun 30, 2017
@weaverryan
feature #50 Add support to enableTypescriptLoader (davidmpaz, weaverr…
d53432a 
…yan)

This PR was merged into the master branch.

Discussion
----------

Add support to enableTypescriptLoader

Hi,

please would you consider adding this to main stream?

this add public API to enable TypeScript loader ([ts-loader](https://github.com/TypeStrong/ts-loader)). It follows much of what is described in #9

Cuurrently only add vanilla loader as described in [here](https://github.com/TypeStrong/ts-loader/blob/master/examples/vanilla/webpack.config.js) playing side by side with babel.

Future work would be to include also support to `happypack` and `fork-ts-checker-webpack-plugin`

Thanks in advance

Commits
-------

6d5dee8 Fixing bad merge
35d9e6f Merge branch 'master' into typescript
82e17e3 Remove unnecessary functional test
4d5319d Update yarn.lock with typescript deps
144acd2 Cleaning up unnecessary code.
f6bc6e7 Rename to enableTypeScriptLoader
facc132 Remove package-lock.json
25b9f18 Remove duplicated default configuration options
23619b2 Add test for error handling on missing ts loader
d887a79 Add typescript to missing loader error handling
61370ac Add .ts & .tsx to resolved extension
6ec2b52 Revert "Add .idea directory to gitignore rules"
356aaa2 Make tests check for content in browser context
822ceff Improve tests for compiling .tsx files
ae1bea3 Update packages-lock.json file
a02d8ab Add .idea directory to gitignore rules
32c2853 Revert accidental version change
846d142 Update tests to take into account refactoring
b43f5c9 Refactor to favor configure by callback
1352d1c Add missing extensions to config.resolve
7e8c118 Fix copy'n paste errors
58b7ef7 Add unit and functional test for TypeScript loader
fc26e1b Add support to enable TypeScript loader
weaverryan added a commit that referenced this issue Jul 2, 2017
@weaverryan
bug #64 Fix missing comma and lint index (davidmpaz)
bde9631 
This PR was squashed before being merged into the master branch (closes #64).

Discussion
----------

Fix missing comma and lint index

This fix #62 and adds index.js to lint task to avoid such things in future.

Missing comma is related to #50. I believe the merge remove it by accident.

Commits
-------

e44bd38 Add index.js to linter
9675c1b Add missing comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing comma and lint index
2 participants
@robertfausk @nandakumardevadas