Fix missing comma and lint index #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2017 09:34
stof
approved these changes
Jun 30, 2017
davidmpaz
referenced
this pull request
Jun 30, 2017
…yan) This PR was merged into the master branch. Discussion ---------- Add support to enableTypescriptLoader Hi, please would you consider adding this to main stream? this add public API to enable TypeScript loader ([ts-loader](https://github.com/TypeStrong/ts-loader)). It follows much of what is described in #9 Cuurrently only add vanilla loader as described in [here](https://github.com/TypeStrong/ts-loader/blob/master/examples/vanilla/webpack.config.js) playing side by side with babel. Future work would be to include also support to `happypack` and `fork-ts-checker-webpack-plugin` Thanks in advance Commits ------- 6d5dee8 Fixing bad merge 35d9e6f Merge branch 'master' into typescript 82e17e3 Remove unnecessary functional test 4d5319d Update yarn.lock with typescript deps 144acd2 Cleaning up unnecessary code. f6bc6e7 Rename to enableTypeScriptLoader facc132 Remove package-lock.json 25b9f18 Remove duplicated default configuration options 23619b2 Add test for error handling on missing ts loader d887a79 Add typescript to missing loader error handling 61370ac Add .ts & .tsx to resolved extension 6ec2b52 Revert "Add .idea directory to gitignore rules" 356aaa2 Make tests check for content in browser context 822ceff Improve tests for compiling .tsx files ae1bea3 Update packages-lock.json file a02d8ab Add .idea directory to gitignore rules 32c2853 Revert accidental version change 846d142 Update tests to take into account refactoring b43f5c9 Refactor to favor configure by callback 1352d1c Add missing extensions to config.resolve 7e8c118 Fix copy'n paste errors 58b7ef7 Add unit and functional test for TypeScript loader fc26e1b Add support to enable TypeScript loader
Closed
Closed
Closed
jdreesen
approved these changes
Jul 1, 2017
|
Is there a merge and publish ETA? |
|
Thanks for the fix! And apologies for the delay - I was away from my keyboard for a moment! I'll tag immediately |
weaverryan
added a commit
that referenced
this pull request
Jul 2, 2017
This PR was squashed before being merged into the master branch (closes #64). Discussion ---------- Fix missing comma and lint index This fix #62 and adds index.js to lint task to avoid such things in future. Missing comma is related to #50. I believe the merge remove it by accident. Commits ------- e44bd38 Add index.js to linter 9675c1b Add missing comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #62 and adds index.js to lint task to avoid such things in future.
Missing comma is related to #50. I believe the merge remove it by accident.