Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating css-loader dep and ts-loader dev dep #440

Closed
wants to merge 3 commits into from
Closed

updating css-loader dep and ts-loader dev dep #440

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6637a1
updating css-loader dep and ts-loader dev dep
weaverryan Nov 9, 2018
241e8ae
Adds optimize-css-assets-webpack-plugin
weaverryan Nov 9, 2018
9d1b00c
Fixing issue where sourcemaps were not dumped in production
weaverryan Nov 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"babel-loader": "^8.0.0",
"chalk": "^2.4.1",
"clean-webpack-plugin": "^0.1.19",
"css-loader": "^0.28.10",
"css-loader": "^1.0.0",
"fast-levenshtein": "^2.0.6",
"file-loader": "^1.1.10",
"friendly-errors-webpack-plugin": "^1.7.0",
Expand Down Expand Up @@ -82,7 +82,7 @@
"sinon": "^2.3.4",
"stylus": "^0.54.5",
"stylus-loader": "^3.0.2",
"ts-loader": "^4.3.0",
"ts-loader": "^5.3.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in devDependencies, so it really just means that we test against this version - the user can install something lower, but they will get a warning. We could also set this to ^5.0.0, which would mean we would test against 5.0.0 in one our test suites. When the user needs to install this, they would be give the command yarn add ts-loader ^5.0.0, but that should install the latest version anyways.

"typescript": "^2.3.4",
"url-loader": "^1.0.1",
"vue": "^2.3.4",
Expand Down