Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comma #70

Closed
wants to merge 1 commit into from
Closed

Fix comma #70

wants to merge 1 commit into from

Conversation

gaiaz-iusipov
Copy link

No description provided.

@jdreesen
Copy link
Contributor

jdreesen commented Jul 1, 2017

This is already the fifth PR for this missing comma (#64, #67, #68, #69).
I think #64 will be the one that gets merged because it updates the linter to prevent this in the future.
But it should be merged soon, to prevent even more PRs for this very issue.

@gaiaz-iusipov gaiaz-iusipov mentioned this pull request Jul 1, 2017
Closed
@weaverryan
Copy link
Member

Thanks! I've merged #64 and just tagged 0.9.1. If I disappear for 1 day, MANY people open a PR for my mistake. That's actually pretty cool :).

Cheers!

@weaverryan weaverryan closed this Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelLH NoelLH NoelLH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaiaz-iusipov @jdreesen @weaverryan @NoelLH