feat: add ESLint 6 support #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
approved these changes
Apr 17, 2020
weaverryan
reviewed
Apr 17, 2020
|
@Lyrkan and I are discussing the version. What I can’t remember is if the version here will affect the “yarn add” that’s displayed if eslint is missing. That was my main motivator for allowing 5 or 6 - I want to make sure that it doesn’t give you a command that would allow version 7 to be installed when it comes out (until we can verify we’re compatible). But I’m not at a computer at the moment to check :) |
weaverryan
force-pushed
the
feat/eslint-6-support
branch
from
72884a7
to
aa8353f
Compare
|
Thank you @Kocal! |
weaverryan
added a commit
that referenced
this pull request
Apr 18, 2020
This PR was merged into the master branch. Discussion ---------- build(deps-dev): update eslint-loader to ^3 eslint-loader ^3 is the last version to [support both ESLint 5 and 6](https://github.com/webpack-contrib/eslint-loader/blob/v3.0.4/package.json#L40) (related #732). Given the [changelog for v3.0.0](https://github.com/webpack-contrib/eslint-loader/blob/master/CHANGELOG.md#300-2019-08-24), the only breaking changes are: - drop support for Node < 8.9.0 (we did it too #731) - minimum supported webpack version is 4: not a problem - minimum supported eslint version is 5: not a problem Commits ------- bd641a9 build(deps-dev): update eslint-loader to ^3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone on Slack had an issue with Encore and ESLint 6:
CLIEngine#configdoes not exists on ESLint 6 anymore, since 6ae21a4b.Now we can use
CLIEngine#getConfigForFileto get the ESLint configuration.Encore now supports both ESLint 5 and 6.
cc @a-menshchikov 😄