New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): update eslint-loader to ^3 #733

Merged

weaverryan merged 1 commit into symfony:master from Kocal:build/update-eslint-loader

Apr 18, 2020

Contributor

Kocal commented Apr 17, 2020 •

edited

eslint-loader ^3 is the last version to support both ESLint 5 and 6 (related #732).

Given the changelog for v3.0.0, the only breaking changes are:

drop support for Node < 8.9.0 (we did it too Upgrade file-loader and allowed version for url-loader, drop Node 8 support #731)
minimum supported webpack version is 4: not a problem
minimum supported eslint version is 5: not a problem


          build(deps-dev): update eslint-loader to ^3

bd641a9

eslint-loader is the last version to [support both ESLint 5 and 6](https://github.com/webpack-contrib/eslint-loader/blob/v3.0.4/package.json#L40).

Given the [changelog for v3.0.0](https://github.com/webpack-contrib/eslint-loader/blob/master/CHANGELOG.md#300-2019-08-24), the only breaking changes are:
- drop support for Node < 8.9.0 (we did it too symfony#731)
- minimum supported webpack version is 4: not a problem
- minimum supported eslint version is 5: not a problem

weaverryan force-pushed the build/update-eslint-loader branch from 0533e68 to bd641a9 Compare

April 18, 2020 00:35

Member

weaverryan commented Apr 18, 2020

Thank you again @Kocal!

weaverryan merged commit b49ee6b into symfony:master

Kocal deleted the build/update-eslint-loader branch

April 18, 2020 05:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment