feat: upgrade sass-loader support to ^8 #736
Conversation
Kocal
force-pushed
the
feat/sass-loader-8
branch
2 times, most recently
from
656c0f1
to
8b38680
Compare
Kocal
force-pushed
the
feat/sass-loader-8
branch
from
8b38680
to
3c6eff2
Compare
Weird fail... since it is on the "Lowest versions" job you can either:
In my opinion it would probably be better to avoid |
|
Hum, that's weird... Does it mean that I don't have to fix this issue there, and we can ignore CI failures to review and merge this PR? Because ATM, the only reason I keep this PR as draft is because of the CI failure 😅 |
|
I found the issue. Just change the order in the test so that the test passes. In Webpack 4.22.0, a "deterministic ordering bug" was apparently fixed - https://github.com/webpack/webpack/releases/tag/v4.22.0 - I believe that caused Webpack to start outputting things in a different order. I don't think it's actually a problem - just something that's different before and after this version. Because this PR bumps Webpack higher than 4.22, it shouldn't be problem. Though... I'm puzzled as to why this wouldn't cause the tests to fail across all builds... since all builds now use higher than 4.22. So maybe I'm still missing a piece of the puzzle. I DO know that, on my Vue3 PR, I determined that Webpack 4.22.0 was the version that "toggled" the different |
Webpack 4.36.0 is the minimum version that sass-loader 8 requires. - 4.20.0 has been released in september 2018: https://github.com/webpack/webpack/releases/tag/v4.20.0 - 4.36.0 has been released in july 2019: https://github.com/webpack/webpack/releases/tag/v4.36.0
|
PR rebased and conflicts fixed. |
|
@weaverryan as it was not deterministic before, it is possible that it would fail only randomly... |
|
Closing in favor of #758 - I got the weird test failure figured out over there :) |
This PR was merged into the master branch. Discussion ---------- Feat/sass loader 8 Fixes weird test issue for #736 - I'm trying to see if I can debug the "lowest" test failure. It appears the problem is with Webpack > 4.22 and Vue < 2.5.0. Commits ------- fb24ca7 Vue 2.5.0 as minimum 9911316 build(deps): upgrade webpack version to ^4.36.0 960481f feat: upgrade sass-loader support to ^8
Close #654
Breaking changes from
sass-loaderchangelog:webpackversion is 4.36.0: done in 4411c45, however a test is failing with lowest dependenciesnode.jsversion is 8.9.0: not an issue since we don't support Node 8 anymore (Upgrade file-loader and allowed version for url-loader, drop Node 8 support #731)sassOptionsoption: ok@Lyrkan do you have an idea oh what to do with the failing test? Use
DISABLE_UNSTABLE_CHECKSon it?Thanks!