Feat/sass loader 8 #758
Merged
Feat/sass loader 8 #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
feat/sass-loader-8
branch
6 times, most recently
from
cdfec57
to
317d728
Compare
weaverryan
changed the title
|
This is ready! |
Lyrkan
approved these changes
May 10, 2020
|
Nice! |
Webpack 4.36.0 is the minimum version that sass-loader 8 requires. - 4.20.0 has been released in september 2018: https://github.com/webpack/webpack/releases/tag/v4.20.0 - 4.36.0 has been released in july 2019: https://github.com/webpack/webpack/releases/tag/v4.36.0
Fixes an inconsistent test with different Webpack versions
weaverryan
force-pushed
the
feat/sass-loader-8
branch
from
317d728
to
fb24ca7
Compare
|
Thank you @Kocal! |
|
Thank you too! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes weird test issue for #736 - I'm trying to see if I can debug the "lowest" test failure.
It appears the problem is with Webpack > 4.22 and Vue < 2.5.0.