-
Notifications
You must be signed in to change notification settings - Fork 145
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify geo_factors_codegen w/ skip_dir_nesting
Previously, `geo_factors_codegen.py` was using an ad-hoc system of generating all the C++ factors into a `factors` folder. It did this by calling `Codegen.generate_function` to generate the code into a temporary file, read the file into a string, then re-wrote the string into the desired location. I assume this was to avoid all the fluff that's generated by default with `Codegen.generate_function`. However, there is the `skip_directory_nesting` optional argument for `Codegen.generate_function` which does precisely that (I think the code in this file might have been written before that option was added). So, to reduce confusion (such as the confusion I faced when I first started looking at this file) and complexity, I rewrote the code to instead use the `skip_directory_nesting` argument. Topic: geo_factors_use_skip_directory_nesting
- Loading branch information
1 parent
4c36881
commit f9a6f2d
Showing
1 changed file
with
13 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters