devel/improvements #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously config() would return a reference to whatever was loaded from _load_config(). Changes to that structure would result in changes to the return value of ->config leading to an invalid cache issue. The dclone ensures that config will persist in returning the value from _load_config(). Storable has been core since 5.7.3, and a result has not been added to the Makefile.PL as a requirement.
This was able to be done in native Perl trivially and should not require adding a dependency to be installed.
Password is the key used in DBI/DBIC for password authentication, pass has been used incorrectly. This has been corrected in the test files.
This allows connect() lines to contain keys to over write the loaded configuration. Any specified configuration will be added to, or replace the loaded configuration. The dsn itself may not be replaced by default.
* Storable wasn't core until 5.7.3, while we support 5.005+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.