Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux client fails to start due to invalid cursor size #5087

Closed
Malcolmlowe opened this issue Nov 4, 2015 · 0 comments
Closed

Linux client fails to start due to invalid cursor size #5087

Malcolmlowe opened this issue Nov 4, 2015 · 0 comments
Assignees
Labels

Comments

@Malcolmlowe
Copy link
Contributor

Reported by Chris S.

  1. Start synergyc
  2. Fails to start.

Expected: Synergy client starts
Actual: Doesn't start.

Solution:

I've tracked the problem back to the libX11 function XQueryBestCursor which
seems to be returning a successful status (True) but also returning values of 0 for 'h' and 'w'.

The call is in your source code
synergy/src/lib/platform/XWindowsScreen.cpp
inside ( method createBlankCursor ).

If the returned valud for h or w is equal to 0, then the subsequent call to XCreatePixmapCursor fails.

The fix I implemented, which seemed to work, was just to add the following lines after the XQueryBestCursor call:

if(w <= 0)
{
w=1;
}

if(h <= 0)
{
h=1;
}

@xhou-wavefin xhou-wavefin changed the title Synergyc fails to start - Fedora 22 Client fails to start due to invalid cursor size Nov 9, 2015
@xhou-wavefin xhou-wavefin changed the title Client fails to start due to invalid cursor size Linux client fails to start due to invalid cursor size Nov 9, 2015
@nlyan nlyan added this to the v1.8.3.0-beta milestone Jun 17, 2016
@nlyan nlyan self-assigned this Jun 17, 2016
nlyan pushed a commit that referenced this issue Jun 17, 2016
…xmap.

XQueryBestCursor sometimes returns 0 for both width and height of the
cursor pixmap. Also caused #5322 and #5068
nlyan pushed a commit that referenced this issue Jun 17, 2016
XQueryBestCursor sometimes returns 0 for both width and height of the
cursor pixmap. Also caused #5322 and #5068
@nlyan nlyan closed this as completed Jun 17, 2016
@xhou-wavefin xhou-wavefin modified the milestones: v1.8.2.2-beta, v1.8.3.0-beta Aug 4, 2016
@xhou-wavefin xhou-wavefin reopened this Aug 4, 2016
nlyan pushed a commit that referenced this issue Aug 4, 2016
XQueryBestCursor sometimes returns 0 for both width and height of the
cursor pixmap. Also caused #5322 and #5068
@nlyan nlyan closed this as completed Aug 4, 2016
xhou-wavefin pushed a commit that referenced this issue Aug 8, 2016
XQueryBestCursor sometimes returns 0 for both width and height of the
cursor pixmap. Also caused #5322 and #5068
nbolton pushed a commit that referenced this issue May 3, 2019
XQueryBestCursor sometimes returns 0 for both width and height of the
cursor pixmap. Also caused #5322 and #5068
nbolton pushed a commit that referenced this issue May 3, 2019
XQueryBestCursor sometimes returns 0 for both width and height of the
cursor pixmap. Also caused #5322 and #5068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants