Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the building of tests with CMake option #6725

Closed
Jnewbon opened this issue Jul 14, 2020 · 0 comments · Fixed by #6726
Closed

Disable the building of tests with CMake option #6725

Jnewbon opened this issue Jul 14, 2020 · 0 comments · Fixed by #6726
Labels
enhancement
Milestone
Sprint 2020-07-13

Comments

@Jnewbon
Copy link
Contributor

Jnewbon commented Jul 14, 2020

Problem

Currently the CMake will always build the tests some of which have headers/test code in non test files.

Solution

Add an option to turn off the test and #ifdef any code for tests that are not in a dedicated test code file
@Jnewbon Jnewbon changed the title Disable the buling of tests with CMake option Disable the building of tests with CMake option Jul 14, 2020
Jnewbon pushed a commit that referenced this issue Jul 14, 2020
@pieterjanc @Jnewbon
#6725 allow building of synergy without tests
16bccc2 
Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
Signed-off-by: Jamie Newbon <jamie@symless.com>
Jnewbon added a commit that referenced this issue Jul 14, 2020
@Jnewbon
#6725 Updated changelog
2420232 
Signed-off-by: Jamie Newbon <jamie@symless.com>
@pieterjanc pieterjanc mentioned this issue Jul 14, 2020
Closed
@Jnewbon Jnewbon linked a pull request Jul 14, 2020 that will close this issue
Compile time argument to skip building tests #5943
Closed
@Jnewbon Jnewbon mentioned this issue Jul 14, 2020
Merged
@Jnewbon Jnewbon added this to the Sprint 2020-07-13 Jedi milestone Jul 14, 2020
@Jnewbon Jnewbon mentioned this issue Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Sprint 2020-07-13
Development

Successfully merging a pull request may close this issue.

Disable test with cmake option symless/synergy-core
Compile time argument to skip building tests
1 participant
@Jnewbon