Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line option for custom TLS Certificate #6736

Closed
Jnewbon opened this issue Jul 27, 2020 · 1 comment · Fixed by #6737
Closed

Command line option for custom TLS Certificate #6736

Jnewbon opened this issue Jul 27, 2020 · 1 comment · Fixed by #6737
Assignees
@Jnewbon
Labels
enhancement
Milestone
Sprint 2020-07-27

Comments

@Jnewbon
Copy link
Contributor

Jnewbon commented Jul 27, 2020

Problem

With system scoped configuration the TLS cert is stored in the users profile so if a new user logs in with a system config available Synergy will create a new cert and prompt the user about the fingerprint

Solution

Add an option to specify the TLS certificate location
@Jnewbon Jnewbon added this to the Sprint 2020-07-27 Jedi milestone Jul 27, 2020
@Jnewbon Jnewbon removed the triage label Jul 27, 2020
@Jnewbon
Copy link
Contributor Author

Jnewbon commented Jul 27, 2020

This issue will only covers adding the ability to specify a custom certificate on the command line. #6669 will handle adding GUI options for custom certificate

Jnewbon referenced this issue Jul 27, 2020
@Jnewbon
#6734 Added new cmd option --tls-cert
6684b8b 
 - Moved ArgsBase, ClientArgs, and ServerArgs to own namespace
 - Added some Documentation to Args classes

Signed-off-by: Jamie Newbon <jamie@symless.com>
@Jnewbon Jnewbon self-assigned this Jul 27, 2020
@Jnewbon Jnewbon mentioned this issue Jul 27, 2020
Merged
@Jnewbon Jnewbon changed the title System config setting for TLS certificate Command line option for custom TLS Certificate Jul 27, 2020
Jnewbon added a commit that referenced this issue Jul 28, 2020
@Jnewbon
#6736 Updated ChangeLog
e08423b 
Signed-off-by: Jamie Newbon <jamie@symless.com>
Jnewbon added a commit that referenced this issue Jul 28, 2020
@Jnewbon
#6736 Fixed failing test on windows and mac
7571288
@Jnewbon Jnewbon mentioned this issue Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jnewbon Jnewbon

Labels
enhancement
Projects
None yet
Milestone
Sprint 2020-07-27
Development

Successfully merging a pull request may close this issue.

Added command line option for custom TLS certificate symless/synergy-core
1 participant
@Jnewbon