Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYNERGY-322 Synergy loses edition when creating a System scope config #6804

Merged
merged 3 commits into from
Oct 15, 2020
Merged

SYNERGY-322 Synergy loses edition when creating a System scope config #6804

merged 3 commits into from
Oct 15, 2020

Conversation

SerhiiGadzhilov
Copy link
Contributor

No description provided.

@andreacndn andreacndn changed the title SYNERGY-322Synergy loses edition when creating a System scope config SYNERGY-322 Synergy loses edition when creating a System scope config Oct 9, 2020
Jnewbon
Jnewbon suggested changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@Jnewbon Jnewbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i just ran this branch on my computer, and switching to System scope from user scope change me to unlicensed on Linux. I think the key/edition is being changed elsewhere in the code on scope change

Jnewbon
Jnewbon previously approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@Jnewbon Jnewbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning out my system setting resolved the issue. And is working as expected

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Jnewbon Jnewbon merged commit 59e9a1f into master Oct 15, 2020
@Jnewbon Jnewbon deleted the SYNERGY-322-Keep-edition-in-config-if-the-new-config-doesn't-have-it branch October 15, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jnewbon Jnewbon Jnewbon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SerhiiGadzhilov @Jnewbon