Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYNERGY-221 Blocker bugs #6821

Merged
merged 6 commits into from
Oct 30, 2020
Merged

SYNERGY-221 Blocker bugs #6821

merged 6 commits into from
Oct 30, 2020

Conversation

SerhiiGadzhilov
Copy link
Contributor

No description provided.

@SerhiiGadzhilov SerhiiGadzhilov marked this pull request as ready for review October 30, 2020 13:59
Jnewbon
Jnewbon reviewed Oct 30, 2020
View reviewed changes
src/lib/synergy/ProtocolUtil.cpp
namespace {

void
writeInt(UInt32 Value, UInt32 Length, std::vector<UInt8>& Buffer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, removing duplication is always good.

Jnewbon
Jnewbon reviewed Oct 30, 2020
View reviewed changes
Copy link
Contributor

@Jnewbon Jnewbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame we couldn't get higher coverage, but i can see trying to get more would be difficult, and ROI would diminish too much.

Just the header comment and I'm good with this

SerhiiGadzhilov and others added 2 commits October 30, 2020 18:24
@SerhiiGadzhilov @Jnewbon
Update src/lib/synergy/ProtocolUtil.cpp
a099776 
Co-authored-by: Jnewbon <48688400+Jnewbon@users.noreply.github.com>
SYNERGY-221 Fix code smells
2b22fc0
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

59.4% 59.4% Coverage
0.0% 0.0% Duplication

@SerhiiGadzhilov SerhiiGadzhilov merged commit d9d833f into master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jnewbon Jnewbon Jnewbon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SerhiiGadzhilov @Jnewbon