Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special contributor mentions on the about screen #7197

Merged
merged 19 commits into from
Jun 30, 2022
Merged

Special contributor mentions on the about screen #7197

merged 19 commits into from
Jun 30, 2022

Conversation

SerhiiGadzhilov
Copy link
Contributor

@SerhiiGadzhilov SerhiiGadzhilov commented Jun 29, 2022 •
edited

SYNERGY1-1570

@SerhiiGadzhilov SerhiiGadzhilov marked this pull request as ready for review June 29, 2022 14:56
@SerhiiGadzhilov SerhiiGadzhilov changed the title New design for the about screen SYNERGY1-1570 New design for the about screen Jun 29, 2022
@SerhiiGadzhilov SerhiiGadzhilov changed the title SYNERGY1-1570 New design for the about screen New design for the about screen Jun 29, 2022
@SerhiiGadzhilov SerhiiGadzhilov marked this pull request as draft June 29, 2022 15:49
@nbolton nbolton changed the title New design for the about screen Special contributor mentions on the about screen Jun 29, 2022
nbolton
nbolton requested changes Jun 29, 2022
View reviewed changes
ChangeLog Outdated Show resolved Hide resolved
src/gui/src/CreditsLoader.cpp Outdated Show resolved Hide resolved
@SerhiiGadzhilov SerhiiGadzhilov marked this pull request as ready for review June 29, 2022 16:35
nbolton
nbolton previously approved these changes Jun 30, 2022
View reviewed changes
nbolton
nbolton requested changes Jun 30, 2022
View reviewed changes
src/gui/src/AboutDialogBase.ui Outdated Show resolved Hide resolved
src/gui/src/AboutDialogBase.ui Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SerhiiGadzhilov SerhiiGadzhilov merged commit 268b0f6 into master Jun 30, 2022
@SerhiiGadzhilov SerhiiGadzhilov deleted the New-design-for-the-about-screen branch June 30, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbolton nbolton nbolton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SerhiiGadzhilov @nbolton