Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't uppercase the first character of function names #89

Closed
rmanthorpe opened this issue May 1, 2020 · 2 comments
Closed

Don't uppercase the first character of function names #89

rmanthorpe opened this issue May 1, 2020 · 2 comments

Comments

@rmanthorpe
Copy link

excel-d will always convert the first character in the D function being wrapped to uppercase since that is the Excel convention.

This convention is often broken on purpose by Excel add-ins (along with having a common prefix for all functions) to make it clear that the function is not part of the standard Excel functions. It's just a little visual queue that many find helpful. Perhaps this could be decided with a version instead for backward compatibility.

@atilaneves
Copy link
Collaborator

Wouldn't it be better for this to be an option that the user can specify?

@rmanthorpe
Copy link
Author

Yes, that's why I suggested a version, so you can compile with version(NoUpperCase) or something. All or nothing struck me as the right level or granularity - after all the users have control over the code they're wrapping so if they want a mixture they can do it by hand. Now that I think about it another flag for wrapAll might be a better choice!

atilaneves added a commit that referenced this issue May 4, 2020
Fix #89 - allow user to indicate that PascalCase isn't wanted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants