Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WWSympa: Switch to Foundation 6 #170

Closed
ikedas opened this issue Jan 24, 2018 · 8 comments
Closed

WWSympa: Switch to Foundation 6 #170

ikedas opened this issue Jan 24, 2018 · 8 comments

Comments

@ikedas
Copy link
Member

ikedas commented Jan 24, 2018

Currently web interface uses Foundation 5.5.3.

Foundation 5 is slightly older and not expected further maintenance. Foundation for Site 6 would be better. So I propose replacing Foundation bundled in Sympa source with Foundation 6.

Replacement would be better to be done in separate branch, then after careful tests, it may be merged into master (and current sympa-6.2).

If no objection, I'll add branch and work with it. Milestone may be 6.2.28 (by now the next of the next stable).


Notice

(update: 2018-01-31)

  • The foundation6 branch was created. Please use this branch to work for this issue.
  • Feel free to submit PR. However note that base branch of PR should be foundation6 (neither sympa-6.2 nor master).
  • Feel free to merge PR, if you are allowed to do.
@xavierba
Copy link
Contributor

On the same subject, there is also the bundled modernizr. Bundled version is 2.6.2, latest from 2.x branch is 2.8.3. The 2.x branch is unmaintained upstream, which is currently at 3.5.0 (https://modernizr.com/news/modernizr-3-5-0). Let me know if you'd rather want this to be tracked in another issue.
Still on the JS subject, it would be nice to make sure jquery 3 deprecations are addressed and jquery-migrate removed. Again, let me know if you want a new issue for this one.

@ikedas
Copy link
Member Author

ikedas commented Jan 24, 2018

@xavierba, I have no objection to deal with other JS stuff. Because Foundation more or less depends on them (e.g. removal of jquery-migrate would be done).

@racke
Copy link
Contributor

racke commented Jan 24, 2018

Sounds good to me :-)

@ikedas
Copy link
Member Author

ikedas commented Jan 31, 2018

Hi all,
New branch was created.

  • Please read the "Notice" added in the first comment.

Recently, only Foundation has been updated and rendering is broken.

@ikedas ikedas added this to the 6.2.28 milestone Jan 31, 2018
This was referenced Feb 1, 2018
@ikedas
Copy link
Member Author

ikedas commented Apr 27, 2018

PR #187 will be merged into foundation6 in a few days, but this branch will be kept unmerged during Sympa 6.2 beta. Please check out and test code in foundation6 branch.


Update 2018-05-01:

@xavierba
Copy link
Contributor

#290 removes some files that are now useless.

ikedas added a commit that referenced this issue May 19, 2018
Foundation6: Some insignificant fixes #170
@xavierba
Copy link
Contributor

www/Makefile.am fixes: #317

@ikedas
Copy link
Member Author

ikedas commented Jun 17, 2018

Hi everybody,

foundation6 branch was successfully merged. It will be available on the next beta, 6.2.33b.2.

Thanks so much for help!

@ikedas ikedas closed this as completed Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants