[6.2] Rewriting code on list configuration form #13

ikedas · 2017-05-03T06:00:32Z

Entirely refactored edit_list_request.tt2. Simpler and consistent logic to compile configuration

Fixed bugs:

[SourceSup#9741] "percentage of list members in VERP mode" is order by left justified
Access privilege ("read" etc.) of paragraph did not override that of sub-parameter:
- e.g. If "archive" gives "read" privilege and "archive.web_access" gives "write", latter is editable on edit_list form but change is ignored.
[SourceSup#7914] Web interface let define the same email twice as list owner.
[SourceSup#9972] Existing item in member_include list configuration paragraph cannot be removed.
Text parameter values including "%xx" are broken: For example "%a5" is altered to "/", "%3a" to ":".
and several minor flaws.

Changes:

List parameter "cookie" will be masked, even if it is accessible (normally by listmaster).
Obsoleted "date" parameter of following paragraphs: last_instantiation, creation and update.
Internal parameters, e.g. "creation", may not be editable.

Known bug:

If owner_include, editors or editor_include is empty, then [Update] on edit_list form is clicked without any changes, configuration file will be updated.
This seems to be caused by inconsistency of current code to save/load config file, and may be fixed by another pr.

(6 May update)
(8 May update)

* Some widgets have no id attribute. * Incorrect name attributes of some fields, although not used.

…ssible (normally by listmaster).

* Sympa::ListDef: Adding extended field_type: dayofweek, lang, reception, status, unixtime, visibility. * wwsympa.fcgi: Simplified do_edit_list_request a bit.

…agraphs: last_instantiation, creation and update.

Fixed by returning callback to encode results if it is called by web template.

* Some widgets have no id attribute. * Incorrect name attributes of some fields, although not used.

…ssible (normally by listmaster).

* Sympa::ListDef: Adding extended field_type: dayofweek, lang, reception, status, unixtime, visibility. * wwsympa.fcgi: Simplified do_edit_list_request a bit.

…agraphs: last_instantiation, creation and update.

Fixed by returning callback to encode results if it is called by web template.

… handled by templates.

…ic to compile configuration (maybe more or less buggy at present, though). Fixed bug: * [#9741] "percentage of list members in VERP mode" is order by left justified

…wner. Fixed by adding a new validation rule 'unique_paragraph_key'.

…graph cannot be removed Fixed by adding "Delete" checkbox on the side of each array item. Foundation grid is used to align checkboxes.

"read" or more restrictive privileges will be assigned on such parameters.

For example "%a5" to "/", "%3a" to ":". Fixed by removing "unescape_html" filtering on wwsympa. It's no longer sure if once such adjustment was useful.

ikedas added 25 commits April 25, 2017 12:22

[-bug] Trivial modifications on edit_list_request.tt2.

84bd0f2

* Some widgets have no id attribute. * Incorrect name attributes of some fields, although not used.

[-feature] List parameter "cookie" will be masked, even if it is acce…

eef061f

…ssible (normally by listmaster).

[-bug] Typos.

696b598

* Cleanup edit_list_request.tt2: Fixing minor bugs and inconsistencies.

51c2020

* Sympa::ListDef: Adding extended field_type: dayofweek, lang, reception, status, unixtime, visibility. * wwsympa.fcgi: Simplified do_edit_list_request a bit.

[-change] Sympa::ListDef: Obsoleted "date" parameter of following par…

4d0207e

…agraphs: last_instantiation, creation and update.

Copyedit.

475d0b7

Copyedit: Refactoring edit_list_request.tt2

4fd39e8

[-bug] Sympa::Template: Result of [%|optdesc()%] was not HTML-encoded.

c4b9909

Fixed by returning callback to encode results if it is called by web template.

Suppress warning on uninitialized value during test.

3cfc0c2

Refactoring: Introducing {privilege} attribute in list config schema.

88c3536

[-bug] Trivial modifications on edit_list_request.tt2.

d503919

* Some widgets have no id attribute. * Incorrect name attributes of some fields, although not used.

[-feature] List parameter "cookie" will be masked, even if it is acce…

7e16593

…ssible (normally by listmaster).

[-bug] Typos.

5b40855

* Cleanup edit_list_request.tt2: Fixing minor bugs and inconsistencies.

df5110f

* Sympa::ListDef: Adding extended field_type: dayofweek, lang, reception, status, unixtime, visibility. * wwsympa.fcgi: Simplified do_edit_list_request a bit.

[-change] Sympa::ListDef: Obsoleted "date" parameter of following par…

c22029a

…agraphs: last_instantiation, creation and update.

Copyedit.

1851511

Copyedit: Refactoring edit_list_request.tt2

d5066a0

[-bug] Sympa::Template: Result of [%|optdesc()%] was not HTML-encoded.

0a00440

Fixed by returning callback to encode results if it is called by web template.

Suppress warning on uninitialized value during test.

d168c1f

Refactoring: Introducing {privilege} attribute in list config schema.

fcead17

Merge branch 'temp' into 6.2-edit_list-rewrite-2

38bd0b3

Refactoring: Display titles of lang, reception and visibility will be…

6acc12b

… handled by templates.

Refactoring: Description of list topics are handled by templates mostly.

d44f14b

Defaults will be calculated during instantiation.

93f53b6

Entirely refactored edit_list_request.tt2. Simpler and consistent log…

b422e83

…ic to compile configuration (maybe more or less buggy at present, though). Fixed bug: * [#9741] "percentage of list members in VERP mode" is order by left justified

ikedas added bug enhancement labels May 3, 2017

ikedas added 3 commits May 3, 2017 19:33

[bug] [#7914] Web interface let define the same email twice as list o…

a8e862c

…wner. Fixed by adding a new validation rule 'unique_paragraph_key'.

Sympa::ListDef: Fixing inconsistent occurrences.

79e9c75

Typo.

481c9c3

ikedas added 6 commits May 4, 2017 13:42

[bug] [#9972] Existing item in member_include list configuration para…

5889fc6

…graph cannot be removed Fixed by adding "Delete" checkbox on the side of each array item. Foundation grid is used to align checkboxes.

Removing styles no longer used in css.tt2.

557615c

Small fixes.

d42c28a

Small fixes.

d739529

[-bug] Several parameters in input should be canonicalized.

0a3d919

Changes on this PR has mostly been done. Maintaining documentation.

ef03509

ikedas added this to the 6.2.17 milestone May 5, 2017

ikedas added 5 commits May 6, 2017 11:25

[change] Internal parameters, e.g. "creation", may not be editable.

8662fbb

"read" or more restrictive privileges will be assigned on such parameters.

More insignificant inconsistencies in schema.

6b19802

Suppress warnings on uniitinialized value at loading time (maybe typos).

27582d4

No use of $pinfo.

d42ec81

[bug] Text parameter values including "%xx" are broken:

447e0ed

For example "%a5" to "/", "%3a" to ":". Fixed by removing "unescape_html" filtering on wwsympa. It's no longer sure if once such adjustment was useful.

ikedas merged commit a0e618d into sympa-community:sympa-6.2 May 11, 2017

ikedas deleted the 6.2-edit_list-rewrite-2 branch June 27, 2017 03:02

ikedas mentioned this pull request May 16, 2018

Prevent being privileged AND unprivileged owner of a list #298

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[6.2] Rewriting code on list configuration form #13

[6.2] Rewriting code on list configuration form #13

ikedas commented May 3, 2017 •

edited

Loading

[6.2] Rewriting code on list configuration form #13

[6.2] Rewriting code on list configuration form #13

Conversation

ikedas commented May 3, 2017 • edited Loading

ikedas commented May 3, 2017 •

edited

Loading