Add additional upload progress feedback #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This you tested it in other browser to be sure to not create a regression ? |
|
I'm not able to cross-browser test this, unfortunately. I normally use Browserstack for testing, but because it's in-browser it doesn't work with dragging and dropping a file. The change is pretty standard, however. Previously, the extension was using the XmlHttpRequest response progress event, which was just firing at the end of the upload when the browser received a response. This PR switches to using the request progress event which fires as the browser is sending data to the server. |
|
Again, this is pretty nifty too, I wasn't aware of the subtle difference between the two events. Makes sense though! |
brendo
added a commit
that referenced
this pull request
May 5, 2015
Add additional upload progress feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brendan, the progress indicator didn't seem to work for me (at least in Safari 8). This quick change gives me progress bar updates as the files upload.