Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interface for 2.4 #36

Merged
merged 1 commit into from
Apr 29, 2014
Merged

Update interface for 2.4 #36

merged 1 commit into from
Apr 29, 2014

Conversation

nilshoerrmann
Copy link
Contributor

This pull request makes the interface compatible with Symphony 2.4. A few things that need to be done as a consequence:

  • The editor no longer displays sort order and directions in the interface because those values are determined by the first selected Data Source. These values will no longer be posted when saving the DS so they need to be discovered in the PHP
  • The editor now displays the default settings panels for pagination and conditions. The logic on the PHP side needs to be updated to match the core field names.
  • Symphony 2.4 offers a new condition: a forbidden parameter. UDS needs to be updated to respect this setting.

brendo added a commit that referenced this pull request Apr 29, 2014
Interface updates for Symphony 2.4
@brendo brendo merged commit 573efa1 into symphonists:integration Apr 29, 2014
@brendo
Copy link
Member

brendo commented Apr 29, 2014

Thanks for this. I think I might bring the Sort stuff back into the interface somehow, although it wasn't able to be changed, it provided the information that developers may find useful.

@nilshoerrmann
Copy link
Contributor Author

If you do, consider adding it as plain text and not as form elements – I always thought it was confusing to have these elements you couldn't change.

If you add this feature back with form controls, consider allowing auto-updating of the selected Data Source (updating all Data Sources with the values provided by the UDS settings interface).

@nilshoerrmann
Copy link
Contributor Author

If it is only provided as information, it could be visualised within the Duplicator interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants