-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jit renderer #98
Jit renderer #98
Conversation
The launcher thing is interesting. I thought about another approach a while ago and would like to hear your opinion on that. What if we reuse existing Symphony functionality for this? Using pages with an image page type, URL parameter and image data source to create recipes? Modifications could then be defined on a data source level, similar to what we're discussing for text formatters. |
Interesting. Seems a little cumbersome though? The whole Symphony stack has to be loaded to process an image. |
Wouldn't that be the case anyway for using the ModifySymphonyLauncher delegate? But yeah, I guess you're right, would be a little cumbersome. |
This is great! |
@brendo just noticed this - if I understand correctly at this point this does exactly the same thing as JIT currently does right now. And would need to be extended through delegates to tackle the issues you listed correct? If so I can have a look to see if it would help close #97 as I had to add a few other functions when extending the Image class such as a |
Yeah correct :) |
+1000 in this thing @brendo |
Merged as 0f72a2c...18a2b02 Rebased is identical to original: 3629d85..2d8ed7d...0f72a2c..18a2b02 |
If another extension previously registered a custom launcher, the current code would bypass it. This commit makes sure we can still call the previously registered launcher before reverting to the default one. Re #98
This pull request (and branch) is a major overhaul to the architecture of JIT. Instead of a standalone script, JIT is simply another Renderer which inherits all Symphony functionality. This was made possible by Symphony 2.5, which added the
ModifySymphonyLauncher
delegate. This alleviates the major limitation of JIT in that it can now use delegates.I believe this change would make it possible to fix the following by adding in delegates, or with minor changes to the code:
workspace/jit-image-manipulation/filters
, Add support for jCrop cropping mode and ImageCropper extension #73class.image.php
Extendible #97The code in this pull request is far from release quality, but I've pushed up in response to the comment by @jensscherbl that others could probably run with this better than I can. Math and image manipulation are not my strengths, so I'm happy for interested parties to carry on this work and work towards a 2.0 release!