Only request the needed schema in table view #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes uses the array returned by $section->fetchVisibleColumns() in order to create the element names array to pass to the entry manager. This yeilds a nice performance update when a section contains many (hundreads) of fields but only a few of them are needed for the publish table view.
|
Honestly, I don't see any performance difference. Should I increase the number of entries per page, maybe? |
Yes. But you get a real gain when you have a field with hundreds of fields (which, I agree, can be a pain to create). But most importantly: there's no bug? |
|
No, it didn't break, which is good. :-)
My test section has 75 fields — no visible difference, even with 100 entries per page. Maybe my server is too fast. :-)) |
Well, maybe :P The problem was not the webserver tho, it was the DB... I saved 500ms of a request that was taking 2500ms (which is 20% decrease) |
|
After testing by myself and @michael-e it's safe to merge in. |
Closed
jensscherbl
pushed a commit
that referenced
this pull request
May 28, 2017
This changes uses the array returned by $section->fetchVisibleColumns() in order to create the element names array to pass to the entry manager. This yeilds a nice performance update when a section contains many (hundreads) of fields but only a few of them are needed for the publish table view. Rebase of 34bd49f
nitriques
added a commit
that referenced
this pull request
Jun 16, 2017
This changes uses the array returned by $section->fetchVisibleColumns() in order to create the element names array to pass to the entry manager. This yeilds a nice performance update when a section contains many (hundreads) of fields but only a few of them are needed for the publish table view. Rebase of 34bd49f Picked from 92f762b
nitriques
added a commit
that referenced
this pull request
Jun 16, 2017
This changes uses the array returned by $section->fetchVisibleColumns() in order to create the element names array to pass to the entry manager. This yeilds a nice performance update when a section contains many (hundreads) of fields but only a few of them are needed for the publish table view. Rebase of 34bd49f Picked from 92f762b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes uses the array returned by $section->fetchVisibleColumns() in order to create the element names array to pass to the entry manager. This yields a nice performance update when a section contains many (hundreds) of fields but only a few of them are needed for the publish table view.
I do not see how this can't be backward compatible, but I created a PR just to document the change and ask for testers! :)
Thanks!