Logout #2606
Logout #2606
Conversation
They are not needed anymore since we use a auto loader
This commit adds a grunt task (named `php`) that will run phpcs with the PSR-2 standard. Note that you have to install php_codesniffer which has been added as a require-dev lib. Doing `composer install` will mess up Symphony's auto loader, so please `git checkout vendor` after the composer call
This commit introduce a new jQuery plugin called Default Value, which gives a input a source element to value its value from, when a specified event occurs on this source element. This behaviour is switched to off when the users focuses on the input field and then blurs out, leaving a value in the input. This commit also hooks this behaviours on the Data Source name input and on the Event name input. Closes symphonycms#2511
This function should be checking new value for emptiness, but it was checking the database value instead. Additionally, at this point, the database value would always be `NULL`. Changed to use the correct variable.
When there is no data written to the database, return `true` instead of `false`. Logically, the operation is successful. See: http://php.net/manual/en/sessionhandlerinterface.write.php When no data has been read, the read method should return an emtpy string, but it was returning NULL instead. See: http://php.net/manual/en/sessionhandlerinterface.read.php
This way, developer can change the sorting order, which is Symphony's order by default
This change is primarly to make sure we do not have to url encode the xsrf token. Also, the default value for the method is now 30 instead of 20. (the magic 20 number was undocumented). The magic number used in the for loop for the fallback is also replace by the length parameter value: the sorter the nonce, the more iteration we have to make to shuffle things more. Finally the method will now throw an Exception if the length is smaller than 1. Fixes symphonycms#2567
Added support for PHP 7 random_bytes() and the mcrypt package. Re symphonycms#2567
The two SQL statements where mostly the same so they got refactored out. Also, this will provide another extension point for extension developers that inherits from the file upload.
This fixes a fatal error on the install page when the extension folder does not exists
First of all there's a big 'error' on the namespace which never matched as there was a typo. Second if a hash exists; the namespace query is run for no reason as data is overwritten by the if statement underneath.
Fix Namespace Cache Typo & remove useless query
Url seems to be case sensitive now. Closes symphonycms#2580
…onycms#2530) * Set "Sections Index" as default area of default (first) author Because not having a default area isn’t considered in the UI. * Set "/blueprints/sections/" as default area fallback for developers symphonycms#2529 * Fix Whitespace
A very small formatting fix.
PHP 7 cares.
In MySQL 5.7 a datetime field cannot have a default value of "0000-00-00" for the date, the minimum value is "1000-01-01".
This thing really complicates things and should have been removed earlier
This change is to protect our users against a poorly setup server. PHP can allow pretty scary things security-wise, so it's best to make sure things that can only have one valid setting should be enforced. Thanks to @hyp3rlinx for this.
This issue has been discovered by @hyp3rlinx Script and html injection was possible, when the user was authenticated
This prevents XSS from error message, which can be remote messages
Exceptions can come from remote servers (like MySQL or SMTP) and can contain invalid xml data. User exceptions can also break this rule. As a safety precaution, we will wrap message just before ouput. Also, it's worthy to say that multiple calls to General::General::wrapInCDATA() is safe. Fixes symphonycms#2518
It does not have any purpose now since we do not even have a with-selected dropdown anymore on the index page. Fixes symphonycms#2573
This will prevent overwriting the previous values
Not visible element should be made readonly, since the user can't edit them anyways. This fixes a problem where Chrome would auto-fill hidden input and the value would be saved without the user ever seeing it. We already tried to fix the problem usign a standard solution (auto-complete="off", symphonycms#1843 and symphonycms#1841) but it does not work. We also tried a non-standard solution (symphonycms#2258) which was rejected. This change only uses standard solution, even thought it relies on javascript to make things works (it should not be a problem since the backend now heavily relies on javascript)
Also added a grunt task to get the current commit id we have building on
* Accept an array of tags 189b387 While the tag list field always returned string (parameter pool) and array values (XML) in the output, it did only accept a string of tags on post. This commit extends the field to accept an array of tags as well which is helpful, if you are building a tag list widget on the front-end and would like to post back to the system. This change is supposed to be backwards compatible (it doesn't change the behaviour for posted string values). * Fix whitespace 49a5200
The SQL generated by the code introduce in 786d1cc contained errors: 1. A superflous ' was present arount the $bit part twice 2. A opening parenthesis ( was missing at the start of the WHERE clause Re symphonycms#2602 Found when reviewing 7e9c94e
Removing code duplication Re symphonycms#2602
It's redundant and totally not needed. Reduces possible reuse.
chmod can fail for numerous reason, like when the user running php does not have proper rights on the filesystem.
0777 is a dangerous settings and should try to be avoided as a default value. Re: symphonycms/jit_image_manipulation#131
|
What's going on here? Dozens of commits? Somebody messing up the Git repo? I just received the following email:
|
LOL Sorry @michael-e ! @ChoboHub is working with me and looks like he made a mistake! Haha We can close this, we'll figure things out! Sorry again ;) |
|
BTW: the problem is: this PR wants to merge 2.7.x + 1 commit to master. @ChoboHub The PR must be submitted against the 2.7.x branch |
No description provided.