Tag list field: accept an array of tags #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the tag list field always returned string (parameter pool) and array values (XML) in the output, it did only accept a string of tags on post. This commit extends the field to accept an array of tags as well which is helpful, if you are building a tag list widget on the front-end and would like to post back to the system. This change is supposed to be backwards compatible (it doesn't change the behaviour for posted string values).
|
Thanks @nilshoerrmann ! Wanna test/review 0e299c6 too ? (it's in |
nitriques
added a commit
that referenced
this pull request
Jun 17, 2016
Removing code duplication Re #2602
|
Thanks for merging! |
Closed
jensscherbl
pushed a commit
that referenced
this pull request
May 28, 2017
* Accept an array of tags 189b387 While the tag list field always returned string (parameter pool) and array values (XML) in the output, it did only accept a string of tags on post. This commit extends the field to accept an array of tags as well which is helpful, if you are building a tag list widget on the front-end and would like to post back to the system. This change is supposed to be backwards compatible (it doesn't change the behaviour for posted string values). * Fix whitespace 49a5200
jensscherbl
pushed a commit
that referenced
this pull request
May 28, 2017
Removing code duplication Re #2602
nitriques
pushed a commit
that referenced
this pull request
Jun 16, 2017
* Accept an array of tags 189b387 While the tag list field always returned string (parameter pool) and array values (XML) in the output, it did only accept a string of tags on post. This commit extends the field to accept an array of tags as well which is helpful, if you are building a tag list widget on the front-end and would like to post back to the system. This change is supposed to be backwards compatible (it doesn't change the behaviour for posted string values). * Fix whitespace 49a5200 Picked from 7e9c94e
nitriques
pushed a commit
that referenced
this pull request
Jun 16, 2017
* Accept an array of tags 189b387 While the tag list field always returned string (parameter pool) and array values (XML) in the output, it did only accept a string of tags on post. This commit extends the field to accept an array of tags as well which is helpful, if you are building a tag list widget on the front-end and would like to post back to the system. This change is supposed to be backwards compatible (it doesn't change the behaviour for posted string values). * Fix whitespace 49a5200 Picked from 7e9c94e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the tag list field always returned string (parameter pool) and array values (XML) in the output, it did only accept a string of tags on post. This commit extends the field to accept an array of tags as well which is helpful, if you are building a tag list widget on the front-end and would like to post back to the system.
This change is supposed to be backwards compatible (it doesn't change the behaviour for posted string values).