-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[StandaloneLineConstructorParamFixer] Ignore constructor without arguments #32
Conversation
When you have a constructor without arguments, the fixer changes it to: ```diff -protected function __construct() { +protected function __construct( +) { ``` Not sure how to solve this.
I'd skip the |
1 similar comment
I'd skip the |
While running this test locally, I notice that my changes in Upon running it with Xdebug, I notice that the tests use this file:
Is there a developer contributing guideline that I'm missing? I checked out the repo, ran |
@TomasVotruba I think I found a way to solve it. Could you approve the workflow? |
@TomasVotruba Please approve again. Why is there approval needed? |
That's Github default for first-contributors. Do you know how to turn it off? |
Thanks for the fix 👍 |
Thanks for the hint and the merge. Please tag it 💙 |
Expect next week |
When you have a constructor without arguments, the fixer changes it to:
Not sure how to solve this. Any advice?