Remove RequireEnumDocBlockOnConstantListPassRule as reports many fals…

…e positive, better shift to native enums (#119) * Remove RequireEnumDocBlockOnConstantListPassRule as reports many false positive, better shift to native enums * remove related services
symplify · May 19, 2024 · 753627d · 753627d
1 parent a71f91c
commit 753627d
Show file tree

Hide file tree

Showing 20 changed files with 1 addition and 651 deletions.
diff --git a/config/services/services.neon b/config/services/services.neon
@@ -15,7 +15,6 @@ services:
     - Symplify\PHPStanRules\Naming\ClassToSuffixResolver
     - Symplify\PHPStanRules\NodeAnalyzer\AttributeFinder
     - Symplify\PHPStanRules\NodeAnalyzer\EnumAnalyzer
-    - Symplify\PHPStanRules\NodeAnalyzer\MethodCall\MethodCallClassConstFetchPositionResolver
     - Symplify\PHPStanRules\NodeAnalyzer\RegexFuncCallAnalyzer
     - Symplify\PHPStanRules\NodeAnalyzer\RegexStaticCallAnalyzer
     - Symplify\PHPStanRules\NodeFinder\ClassMethodNodeFinder
@@ -26,7 +25,6 @@ services:
     - Symplify\PHPStanRules\PhpDoc\BarePhpDocParser
     - Symplify\PHPStanRules\PhpDoc\PhpDocResolver
     - Symplify\PHPStanRules\Printer\NodeComparator
-    - Symplify\PHPStanRules\Reflection\MethodCallNodeAnalyzer
     - Symplify\PHPStanRules\Reflection\MethodNodeAnalyser
     - Symplify\PHPStanRules\TypeAnalyzer\CallableTypeAnalyzer
     - Symplify\PHPStanRules\Matcher\Collector\PublicClassMethodMatcher

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 44 Rules Overview
+# 43 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -1398,67 +1398,6 @@ final class SomeAttribute
 
 <br>
 
-## RequireEnumDocBlockOnConstantListPassRule
-
-On passing a constant, the method should have an enum type. See https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants
-
-- class: [`Symplify\PHPStanRules\Rules\Enum\RequireEnumDocBlockOnConstantListPassRule`](../src/Rules/Enum/RequireEnumDocBlockOnConstantListPassRule.php)
-
-```php
-final class Direction
-{
-    public const LEFT = 'left';
-
-    public const RIGHT = 'right';
-}
-
-final class Driver
-{
-    public function goToWork()
-    {
-        $this->turn(Direction::LEFT);
-    }
-
-    private function turn(string $direction)
-    {
-        // ...
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-final class Direction
-{
-    public const LEFT = 'left';
-
-    public const RIGHT = 'right';
-}
-
-final class Driver
-{
-    public function goToWork()
-    {
-        $this->turn(Direction::LEFT);
-    }
-
-    /**
-     * @param Direction::*
-     */
-    private function turn(string $direction)
-    {
-        // ...
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ## RequireExceptionNamespaceRule
 
 `Exception` must be located in "Exception" namespace

diff --git a/src/NodeAnalyzer/MethodCall/MethodCallClassConstFetchPositionResolver.php b/src/NodeAnalyzer/MethodCall/MethodCallClassConstFetchPositionResolver.php
diff --git a/src/Reflection/MethodCallNodeAnalyzer.php b/src/Reflection/MethodCallNodeAnalyzer.php
diff --git a/src/Rules/Enum/RequireEnumDocBlockOnConstantListPassRule.php b/src/Rules/Enum/RequireEnumDocBlockOnConstantListPassRule.php