Remove ForbiddenSameNamedNewInstanceRule as rarely a buggy spot (#123)

symplify · May 25, 2024 · a9766b3 · a9766b3
1 parent a23355d
commit a9766b3
Show file tree

Hide file tree

Showing 11 changed files with 1 addition and 326 deletions.
diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 42 Rules Overview
+# 41 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -470,34 +470,6 @@ final class SomeRector implements RectorInterface
 
 <br>
 
-## ForbiddenSameNamedNewInstanceRule
-
-New objects with "%s" name are overridden. This can lead to unwanted bugs, please pick a different name to avoid it.
-
-- class: [`Symplify\PHPStanRules\Rules\Complexity\ForbiddenSameNamedNewInstanceRule`](../src/Rules/Complexity/ForbiddenSameNamedNewInstanceRule.php)
-
-```php
-$product = new Product();
-$product = new Product();
-
-$this->productRepository->save($product);
-```
-
-:x:
-
-<br>
-
-```php
-$firstProduct = new Product();
-$secondProduct = new Product();
-
-$this->productRepository->save($firstProduct);
-```
-
-:+1:
-
-<br>
-
 ## NarrowPublicClassMethodParamTypeByCallerTypeRule
 
 Parameters should use "%s" types as the only types passed to this method

diff --git a/src/Rules/Complexity/ForbiddenSameNamedNewInstanceRule.php b/src/Rules/Complexity/ForbiddenSameNamedNewInstanceRule.php
diff --git a/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SameObjectAssigns.php b/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SameObjectAssigns.php
diff --git a/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipDifferentNames.php b/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipDifferentNames.php
diff --git a/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipForeachNewNesting.php b/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipForeachNewNesting.php
diff --git a/.../Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipForeachVariableAssign.php b/.../Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipForeachVariableAssign.php
diff --git a/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipNonObjectAssigns.php b/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipNonObjectAssigns.php
diff --git a/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipNullDefaultAssign.php b/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipNullDefaultAssign.php
diff --git a/...es/Complexity/ForbiddenSameNamedNewInstanceRule/ForbiddenSameNamedNewInstanceRuleTest.php b/...es/Complexity/ForbiddenSameNamedNewInstanceRule/ForbiddenSameNamedNewInstanceRuleTest.php
diff --git a/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Source/SomeProduct.php b/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Source/SomeProduct.php
diff --git a/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/config/configured_rule.neon b/tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/config/configured_rule.neon