Allow abstract classes to be implemented in NoSingleInterfaceImplemen…

…terRule (#135)
symplify · Jun 2, 2024 · b22fabb · b22fabb
1 parent 3c9b05f
commit b22fabb
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/src/Collector/ImplementedInterfaceCollector.php b/src/Collector/ImplementedInterfaceCollector.php
@@ -18,12 +18,17 @@ public function getNodeType(): string
 
     /**
      * @param Class_ $node
-     * @return string[]
+     * @return string[]|null
      */
-    public function processNode(Node $node, Scope $scope): array
+    public function processNode(Node $node, Scope $scope): ?array
     {
         $implementedInterfaceNames = [];
 
+        // skip abstract classes, as they can enforce child implementations
+        if ($node->isAbstract()) {
+            return null;
+        }
+
         foreach ($node->implements as $implement) {
             $implementedInterfaceNames[] = $implement->toString();
         }

diff --git a/tests/Rules/NoSingleInterfaceImplementerRule/Fixture/AllowAbstract.php b/tests/Rules/NoSingleInterfaceImplementerRule/Fixture/AllowAbstract.php
@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\NoSingleInterfaceImplementerRule\Fixture;
+
+abstract class AllowAbstract implements SimpleInterface
+{
+}
diff --git a/tests/Rules/NoSingleInterfaceImplementerRule/NoSingleInterfaceImplementerRuleTest.php b/tests/Rules/NoSingleInterfaceImplementerRule/NoSingleInterfaceImplementerRuleTest.php
@@ -31,6 +31,7 @@ public function testRule(array $filePaths, array $expectedErrorMessagesWithLines
     public static function provideData(): Iterator
     {
         yield [[__DIR__ . '/Fixture/SimpleInterface.php'], []];
+        yield [[__DIR__ . '/Fixture/AllowAbstract.php', __DIR__ . '/Fixture/SimpleInterface.php'], []];
 
         yield [
             [