Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify the SUFFIX for PR #18

Merged
merged 3 commits into from Jul 28, 2018

Conversation

Projects
None yet
2 participants
@sidhantnagpal
Copy link
Member

sidhantnagpal commented Jul 28, 2018

Fixes #17

sidhantnagpal added some commits Jul 28, 2018

Merge pull request #1 from sidhantnagpal/pr-link-fix
Explicitly specify the SUFFIX for PR
@sidhantnagpal

This comment has been minimized.

Copy link
Member Author

sidhantnagpal commented Jul 28, 2018

It seems the existing tests will need to be modified to account for this change.

@asmeurer

This comment has been minimized.

Copy link
Member

asmeurer commented Jul 28, 2018

Ah dang I guess I never tested this. The existing notes will need to be fixed on the wiki too.

@sidhantnagpal

This comment has been minimized.

Copy link
Member Author

sidhantnagpal commented Jul 28, 2018

I have updated the wiki for the same.

@asmeurer

This comment has been minimized.

Copy link
Member

asmeurer commented Jul 28, 2018

This will break URLs in the test site, and if we decide to use this in any other project. We can figure out how to make it project agnostic later, though. If other projects want to use this we will need to modify quite a bit actually, in order to make it a GitHub app.

@asmeurer asmeurer merged commit 4d6d148 into sympy:master Jul 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.