Explicitly specify the SUFFIX for PR #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly specify the SUFFIX for PR
|
It seems the existing tests will need to be modified to account for this change. |
|
Ah dang I guess I never tested this. The existing notes will need to be fixed on the wiki too. |
|
I have updated the wiki for the same. |
|
This will break URLs in the test site, and if we decide to use this in any other project. We can figure out how to make it project agnostic later, though. If other projects want to use this we will need to modify quite a bit actually, in order to make it a GitHub app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17